[vlc-devel] [PATCH 2/2] live555: Use OPTIONS as keep-alive fallback

[Paul Clark]

On 23/06/15 12:35, Rémi Denis-Courmont wrote:
> Le 2015-06-23 14:26, Paul Clark a écrit :
>> I've seen clients (notably Samsung SmartTVs) do this against our
>> server, so we support it as well as GET_PARAMETER, but it requires the
>> client to send the Session: header with OPTIONS (which is pretty weird
>> RTSP, really, but works), and I don't think your patch can be doing
>> so:
>>
>> +            p_sys->rtsp->sendOptionsCommand(NULL, NULL);
>>
>> Does the SAT>IP spec specify this?
>
> No. SAT>IP requires OPTIONS with a Session header and token, AFAIU:
>
> http://www.satip.info/sites/satip/files/resource/satip_specification_version_1_2_2.pdf 
>
>
> Either way, it makes no sense. The Session header is not allowed in 
> OPTIONS request by RFC2326. But without it, there are no ways to 
> specify which session is being refreshed. The bottom line is that 
> using OPTIONS for refresh is wrong, and should not be attempted unless 
> the server is known to expect this

Sorry, my question was ambiguous, I meant does SAT>IP specify an OPTIONS 
with Session, as I guessed it must.  I agree it's against RFC2326 but 
that's no surprise in RTSP :-/

So unfortunately to make it comply with SAT>IP as per the original 
requirement will require persuading Ross @ live555 to break the RFC and 
accept a MediaSession parameter on RTSPClient::sendOptionsCommand() to 
provide the Session: header. Good luck with that ;-)

I see this has already been accepted in master, but its handling of 
PAUSE is faulty too.  I'm afraid this needs rethinking and (because of 
the dependency on live555 to do what was intended), probably dropping...

Best regards

Paul