[vlc-devel] [PATCH 2/2] live555: Use OPTIONS as keep-alive fallback

[Paul Clark]

On 24/06/15 08:28, Julian Scheel wrote:
> As you pointed out using OPTIONS as keep-alive is not RFC2326 
> compliant, as it would not contain a Session header normally. So this 
> is merely a fallback for SAT>IP, which explicitly does not know the 
> PAUSE command and thus a paused state. Hence the TimeoutPrevention() 
> would not be used at all for SAT>IP sources. Although I must admit 
> that due to the nature of a generic-fallback, not explicitly checking 
> for SAT>IP servers, it is at least a bit confusing to only do it in 
> Demux...

OK, if SAT>IP explicitly disallows PAUSE (which I guess should have been 
obvious, unless they offer pause-live-TV!) then my point about the 
TimeoutPrevention version is pretty irrelevant and it's not worth 
worrying about for SAT>IP itself.

My only remaining worry then is that since you're no longer testing 
whether GET_PARAMETER is advertised for starting the TimeoutPrevention 
thread (p_sys->b_get_param), it would be sending GP during PAUSE to 
servers that haven't advertised it.  They should of course just reject 
it cleanly but I wouldn't put it past some servers to just throw a hissy 
fit and drop the connection - the OPTIONS test for GET_PARAMETER was 
there for a reason.

I think that's fairly easily fixable, though, just by testing that flag 
in TimeoutPrevention before sending GP - I'll come up with a patch later 
because I'm working in this area on the separate PAUSE/GP issue anyway.

Best regards

Paul