[vlc-devel] [PATCH] Handle GET_PARAMETER keepalive responses during PAUSE

Rémi Denis-Courmont remi at remlab.net
Thu Jun 25 18:59:43 CEST 2015


Le 2015-06-25 17:56, Ross Finlayson a écrit :
> Once again, folks: The best way to use the LIVE555 library is to have
> *exactly one* thread that calls LIVE555 functions. This thread (after
> some initialization to set up timer tasks using
> “scheduleDelayedTask()”) would call “doEventLoop()”, without a
> 'watch variable' parameter. In other words, this thread would do
> nothing but run within “doEventLoop()”, and would not block.

Now that's contradictory. If it calls doEventLoop(), it blocks in doing 
so.

> Your
> other threads (i.e., the rest of your application) can continue to do
> whatever they want - except call LIVE555 functions.

And so the other threads need to tell the live555 thread to do 
something. Except they cannot because the live555 is sleeping inside the 
live555 event loop...

> That’s why your “live555.cpp” code is so complex.

No. The VLC code is complex because it evolved organically over time 
and without any kind of plan or vision.

> I urge you to
> (sometime in the future) restructure this code - as noted above - to
> use a single thread that does nothing but run inside
> “doEventLoop()”. This would simplify it considerably.

So far you have _not_ proposed any reasonable way to use live555.

-- 
Rémi Denis-Courmont
http://www.remlab.net/



More information about the vlc-devel mailing list