[vlc-devel] [PATCH] Contrib: fix UPNP building on Win32

[Rémi Denis-Courmont]

Le 2015-03-02 18:32, Jean-Baptiste Kempf a écrit :
> On 02 Mar, Steve Lhomme wrote :
>> Fixes #14057
>> ---
>>  modules/services_discovery/upnp.hpp | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/modules/services_discovery/upnp.hpp 
>> b/modules/services_discovery/upnp.hpp
>> index 23fe4db..09e1bc3 100644
>> --- a/modules/services_discovery/upnp.hpp
>> +++ b/modules/services_discovery/upnp.hpp
>> @@ -28,6 +28,10 @@
>>  #include <vector>
>>  #include <string>
>>
>> +#ifdef _WIN32
>> +# undef if_nametoindex
>> +#endif
>
> Your mingw header is declaring if_nametoindex with the wrong 
> WIN32_WINNT
> guards.

Why is it a problem with UPnP only? Is a UPnP public header is defining 
if_nametoindex()? Library headers should never define standard 
identifiers publicly.

-- 
Rémi Denis-Courmont