[vlc-devel] [PATCH] Contrib: fix UPNP building on Win32
robux4 at videolabs.io
Mon Mar 2 17:01:36 CET 2015
On Mon, Mar 2, 2015 at 5:00 PM, Steve Lhomme <robux4 at videolabs.io> wrote:
> On Mon, Mar 2, 2015 at 4:41 PM, Steve Lhomme <robux4 at videolabs.io> wrote:
>> On Mon, Mar 2, 2015 at 4:32 PM, Jean-Baptiste Kempf <jb at videolan.org> wrote:
>>> On 02 Mar, Steve Lhomme wrote :
>>>> Fixes #14057
>>>> modules/services_discovery/upnp.hpp | 4 ++++
>>>> 1 file changed, 4 insertions(+)
>>>> diff --git a/modules/services_discovery/upnp.hpp b/modules/services_discovery/upnp.hpp
>>>> index 23fe4db..09e1bc3 100644
>>>> --- a/modules/services_discovery/upnp.hpp
>>>> +++ b/modules/services_discovery/upnp.hpp
>>>> @@ -28,6 +28,10 @@
>>>> #include <vector>
>>>> #include <string>
>>>> +#ifdef _WIN32
>>>> +# undef if_nametoindex
>>> Your mingw header is declaring if_nametoindex with the wrong WIN32_WINNT
>> No it's guarded with _WIN32_WINT >= 0x600, which corresponds to the
>> availability in Windows.
> You're right I was looking at the one detected by QtCreator, which is
> correct. The one in my mingw32 folder is wrong.
> It comes from this file that is recommended in the Win32 compile instructions.
> Do we still need this hack ? There's a newer version of this package,
> but the netioapi.h file is still bogus.
More information about the vlc-devel