[vlc-devel] [PATCH] qtcapture: Clarify help text for qtcapture args

Jed Smith jed at jedsmith.org
Sun Mar 8 03:02:03 CET 2015

The maximum resolution encouraged in the help text for the qtcapture
arguments is 1280x480, which doesn't make sense. The patch author
intended to imply 720p but appears to have forgotten the height
dimension. In addition, clean up the help text a bit.

--qtcapture-height works with 720, anyway, so it's just a doc issue.
 modules/access/qtcapture.m | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/modules/access/qtcapture.m b/modules/access/qtcapture.m
index 611b89f..d24f7fd 100644
--- a/modules/access/qtcapture.m
+++ b/modules/access/qtcapture.m
@@ -42,10 +42,10 @@
 #import <QTKit/QTKit.h>
 #import <CoreAudio/CoreAudio.h>

-#define QTKIT_WIDTH_TEXT N_("Video Capture width")
-#define QTKIT_WIDTH_LONGTEXT N_("Video Capture width in pixel")
-#define QTKIT_HEIGHT_TEXT N_("Video Capture height")
-#define QTKIT_HEIGHT_LONGTEXT N_("Video Capture height in pixel")
+#define QTKIT_WIDTH_TEXT N_("Video capture width")
+#define QTKIT_WIDTH_LONGTEXT N_("Video capture width in pixels")
+#define QTKIT_HEIGHT_TEXT N_("Video capture height")
+#define QTKIT_HEIGHT_LONGTEXT N_("Video capture height in pixels")

 * Local prototypes
@@ -69,7 +69,7 @@ vlc_module_begin ()
    add_integer("qtcapture-width", 640, QTKIT_WIDTH_TEXT,
       change_integer_range (80, 1280)
    add_integer("qtcapture-height", 480, QTKIT_HEIGHT_TEXT,
-      change_integer_range (60, 480)
+      change_integer_range (60, 720)
 vlc_module_end ()

Jed Smith
jed at jedsmith.org

More information about the vlc-devel mailing list