[vlc-devel] [PATCH] gestures: fix: allow gesture to be triggered

[Zoran Turalija]

On Fri, Mar 06, 2015 at 08:14:21PM +0100, Zoran Turalija wrote:
> ---
>  modules/control/gestures.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/modules/control/gestures.c b/modules/control/gestures.c
> index 2b40fc4..e928928 100644
> --- a/modules/control/gestures.c
> +++ b/modules/control/gestures.c
> @@ -410,8 +410,7 @@ static int MovedEvent( vlc_object_t *p_this, char const *psz_var,
>          {
>              p_sys->i_last_x = newval.coords.x;
>              p_sys->i_last_y = newval.coords.y;
> -            if( p_sys->i_num_gestures > 0
> -             && gesture( p_sys->i_pattern, p_sys->i_num_gestures - 1 )
> +            if( gesture( p_sys->i_pattern, p_sys->i_num_gestures - 1 )
>                      != pattern )
>              {
>                  p_sys->i_pattern |= pattern << ( p_sys->i_num_gestures * 4 );
> -- 
> 2.1.4
> 

Proposed patch is an attempt to fix current situation regarding mouse
gestures. As it stands right now, mouse gestures are not working at all
on desktop VLC (both linux and windows) since the v2.1.5 release (I don't
know working status on tablet/phone/other devices VLC apps).

Git commit 3d663c8e3b039b4368b2d61b08b3943aafefb056 from Sep 1st 2014
introduced, among other things, additional rule to an “if statement” in
a form of additional check that prohibits triggering of mouse gestures at all.

Maybe some additional check is really needed, but this one is plain wrong,
since it excludes mouse gestures from ever occurring.

I mean, if that was intentional (to prevent mouse gestures at all), then mouse
gestures code should have been removed from source code entirely and for such
case commit message is wrong, but I highly doubt that was the goal of author
that submitted afore mentioned git commit. :P

In that regard either:

  * accept this patch
  * propose better/correct one
  * remove mouse gestures
  * revert commit  3d663c8e3b039b4368b2d61b08b3943aafefb056

Current status quo is not good. Releases v2.1.6 and v2.2.0 are already out
with this bug and current git and future v3.0 release are poisoned with it
as we speak.

-- 
Kind regards,
Zoran Turalija