[vlc-devel] [PATCH] portable windows build

Hannes Domani ssbssa at yahoo.de
Sun Mar 8 16:23:26 CET 2015


Jean-Baptiste Kempf <jb at videolan.org> schrieb am 16:03 Sonntag, 8.März 2015:
> On 08 Mar, Hannes Domani wrote :
> > Jean-Baptiste Kempf <jb at videolan.org> schrieb am 15:39 Sonntag, 8.März 2015:
> > > On 08 Mar, Hannes Domani wrote :
> > > > Jean-Baptiste Kempf <jb at videolan.org> schrieb am 15:15 Sonntag, 8.März 2015:
> > > > > On 08 Mar, Hannes Domani wrote :
> > > > > > This simply checks if there is a "portable" folder where vlc.exe is, and uses it instead of the user AppData directory.
> > > > >
> > > > > Is this detection method the best idea?
> > > >
> > > > The other methods I can think of are an environment variable, or a command line parameter.
> > >
> > > vlc-portable.exe ?
> > >
> > > Or a .portable.txt file?
> >
> > So the detection method should then take care of creating the folder if it doesn't exist yet?
> 
> That's an idea.
> 
> I'm just asking, though, since there is no standard or consensus

After thinking some more, I actually like it best the way it is now.
Part of the reason I made this, is because I can now make my tests in the build-tree without having to fear it interferes with the normal AppData configuration. So vlc-portable.exe would make this more of a hassle.
And a .portable.txt file feels redundant, if the portable folder can indicate portable use by itself.

But, if you want one of those, I don't mind submitting a patch for it (I would just revert it back to the current behavior in my local build).


Regards
Domani Hannes



More information about the vlc-devel mailing list