[vlc-devel] [PATCH] build: create a macro to check for, and replace, possibly-inline functions.

Rémi Denis-Courmont remi at remlab.net
Tue Mar 10 13:54:08 CET 2015

Le 2015-03-10 15:31, Diego Elio Pettenò a écrit :
> On 10 March 2015 at 12:17, Rémi Denis-Courmont <remi at remlab.net> 
> wrote:
>>> +VLC_REPLACE_FUNC_INLINE([gmtime_r], [
>>> +    #define _POSIX_C_SOURCE 200809L
>> Forcing a build environment only for a test is not a good idea 
> That's just a requirement of the gmtime_r feature test macros.

Either we are testing the actual build environment of VLC; and forcing 
POSIX.2008 for just one test is wrong. Or we are testing for the symbol 
existing in general, and there is no need to patch anything.

So I find having that #define in patch self-contradictory.

Rémi Denis-Courmont

More information about the vlc-devel mailing list