[vlc-devel] [PATCH 0/2] Fix URL option parsing

Rémi Denis-Courmont remi at remlab.net
Tue Mar 10 15:54:16 CET 2015

Havent had time to read the patches but in any case fix the bug before you fix the test. Unless you want git-bisect to point the finger at you all the time.

Rémi Denis-Courmont
Sent from my NVIDIA Tegra-powered device

----- Reply message -----
De : "Hugo Beauzée-Luyssen" <hugo at beauzee.fr>
Pour : <vlc-devel at videolan.org>
Objet : [vlc-devel] [PATCH 0/2] Fix URL option parsing
Date : mar., mars 10, 2015 16:45


vlc_UrlParse's options parsing seems to be broken.
The attached addition to the test suite shows that psz_option is always NULL, 
which makes sense since we're using strchr on a string that has been forced 
to contain nothing but a '\0'

Hugo Beauzée-Luyssen (2):
Add vlc_UrlParse tests
text: url: Fix options parsing

src/test/url.c | 26 ++++++++++++++++++++++++++
src/text/url.c |  2 +-
2 files changed, 27 insertions(+), 1 deletion(-)


vlc-devel mailing list
To unsubscribe or modify your subscription options:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20150310/ef9aef7f/attachment.html>

More information about the vlc-devel mailing list