[vlc-devel] [PATCH] MKV: rework the PCR to match what avformat does

[Steve Lhomme]

On Thu, Mar 12, 2015 at 6:27 PM, Francois Cartegnie <fcvlcdev at free.fr> wrote:
> Le 12/03/2015 15:37, Steve Lhomme a écrit :
>> Fixes #13575
>> Fixes #11847 which had time display issues
>>
>> The new PCR logic is borrowed from
>> http://git.videolan.org/?p=vlc.git;a=blob;f=modules/demux/avformat/demux.c;hb=HEAD#l776
>>
>> The PCR is now set just before sending the packet es_out_Send() rather than
>> before treating the new read Block (ie the previous PCR value)
>
> Should always be, and no packet should be sent without PCR set.

Well, there's the case of 0. It's not set because that's also the
value of VLC_TS_INVALID. Should they be shifted with VLC_TS_0 ? Will
there be issues between the actual pts/dts of the packet if they are
not shifted ?

Steve