[vlc-devel] [PATCH] Win32: Fix supported types not registered properly by NSIS installer

Jean-Baptiste Kempf jb at videolan.org
Mon Mar 16 14:33:49 CET 2015


Applied, thanks.

On 16 Mar, Jonathan McGowan wrote :
> 
> A bad parameter definition in function RegisterExtension resulted in the same value entry being written every time ("${EXT}"="").
> ---
>  extras/package/win32/NSIS/helpers/extensions.nsh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/extras/package/win32/NSIS/helpers/extensions.nsh b/extras/package/win32/NSIS/helpers/extensions.nsh
> index 3afcffb..760d0e5 100644
> --- a/extras/package/win32/NSIS/helpers/extensions.nsh
> +++ b/extras/package/win32/NSIS/helpers/extensions.nsh
> @@ -21,7 +21,7 @@ Function RegisterExtension
>    WriteRegStr HKCR "VLC$R0\shell\Open" "MultiSelectModel" "Player"
>    WriteRegStr HKCR "VLC$R0\shell\Open\command" "" '"$INSTDIR\vlc.exe" --started-from-file "%1"'
>    WriteRegStr HKCR "VLC$R0\DefaultIcon" "" '"$INSTDIR\vlc.exe",0'
> -  WriteRegStr HKCR "Applications\vlc.exe\SupportedTypes" ${EXT} ""
> +  WriteRegStr HKCR "Applications\vlc.exe\SupportedTypes" $0 ""
>  
>    ${If} ${AtLeastWinVista}
>      WriteRegStr HKLM "Software\Clients\Media\VLC\Capabilities\FileAssociations" "$R0" "VLC$R0"
> -- 
> 2.1.0
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

-- 
With my kindest regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device



More information about the vlc-devel mailing list