[vlc-devel] [PATCH] Implementing a shortcut for search in playlist

[Ilkka Ollakka]

On Mon, Mar 16, 2015 at 05:35:19PM +0530, shreshtha mundra wrote:

Hi,

> Implementation of a shortcut "ctrl+]"  for search option in playlist.
> https://trac.videolan.org/vlc/ticket/13865

> Shreshtha Mundra

> From 1f5d9143b9ac9ce843864f91d18b049558d993d2 Mon Sep 17 00:00:00 2001
> From: shreshtha <mundra.shreshtha at gmail.com>
> Date: Mon, 16 Mar 2015 17:13:53 +0530
> Subject: [PATCH] Shortcut for search in playlist implemented. Shortcut key is
>  ctrl+], after opening the playlist widget

> ---
>  modules/demux/ts.c                               | 211 ++++++++++-------------
>  modules/gui/qt4/components/playlist/playlist.cpp |   6 +
>  modules/packetizer/mpeg4audio.c                  |  20 ++-
>  po/bn.po                                         |   2 +-
>  po/gu.po                                         |   2 +-
>  po/mn.po                                         |   2 +-
>  po/my.po                                         |   2 +-
>  po/nb.po                                         |   2 +-
>  po/ne.po                                         |   2 +-
>  po/or.po                                         |   2 +-
>  src/network/httpd.c                              |  18 +-
>  11 files changed, 130 insertions(+), 139 deletions(-)

Your commit contains quite a lot of not-comment/title related changes,
please make sure you send only the changeset that comment and title
mentions.


...
> diff --git a/modules/gui/qt4/components/playlist/playlist.cpp b/modules/gui/qt4/components/playlist/playlist.cpp
> index 7091805..8a3e186 100644
> --- a/modules/gui/qt4/components/playlist/playlist.cpp
> +++ b/modules/gui/qt4/components/playlist/playlist.cpp
> @@ -41,6 +41,7 @@
>  #include <QSignalMapper>
>  #include <QSlider>
>  #include <QStackedWidget>
> +#include <QShortcut>

>  /**********************************************************************
>   * Playlist Widget. The embedded playlist
> @@ -124,6 +125,11 @@ PlaylistWidget::PlaylistWidget( intf_thread_t *_p_i, QWidget *_par )
>      searchEdit->setMinimumWidth( 80 );
>      searchEdit->setToolTip( qtr("Search the playlist") );
>      topbarLayout->addWidget( searchEdit );
> +
> +
> +    QShortcut* shortcut = new QShortcut(QKeySequence("Ctrl+]"), this);
> +    QObject::connect(shortcut, SIGNAL(activated()), searchEdit, SLOT(setFocus()));
> +
>      CONNECT( searchEdit, textChanged( const QString& ),
>               mainView, search( const QString& ) );
>      CONNECT( searchEdit, searchDelayedChanged( const QString& ),
...

This seems to be only related changeset, others most likely not.

-- 
Ilkka Ollakka
"Just think, with VLSI we can have 100 ENIACS on a chip!"
		-- Alan Perlis