[vlc-devel] [PATCH 3/3] playlist: fetcher: fix memory leaks

Rémi Denis-Courmont remi at remlab.net
Mon Mar 16 18:29:24 CET 2015

Le vendredi 13 mars 2015, 18:36:10 Hannes Domani a écrit :
> Unless there is a non-obvious reason p_fetcher->albums shouldn't be freed.

There is a very sad non-obvious reason: AFAICT, the fetcher fails to perform 
*any* garbage collection. In fact, its memory *and* time complexity both 
increase linearly as the playlist expands.

Then again, so does the playlist proper: items are never freed even if they 
are deleted from the playlist.

This patch is really just a brown paper bag :-( I am not even sure if it 
improves the situation, because it will hide the leak rather than fix it.

Rémi Denis-Courmont

More information about the vlc-devel mailing list