[vlc-devel] [PATCH] directsound: make StreamTimeGet() return logic similar to OutputTimeGet()

[Rémi Denis-Courmont]

Le 2015-03-17 15:59, Steve Lhomme a écrit :
> Fixes #14186
>
> 
> http://streams.videolan.org/misc/test-files-ccc/%5bCCCP%5d_Mega_Audio_Test.mkv
> still stutters with Vorbis 6ch, it doesn't in 2.2.0
> ---
>  modules/audio_output/directsound.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/modules/audio_output/directsound.c
> b/modules/audio_output/directsound.c
> index 2a1a06d..e695ee1 100644
> --- a/modules/audio_output/directsound.c
> +++ b/modules/audio_output/directsound.c
> @@ -178,7 +178,7 @@ static HRESULT TimeGet( aout_stream_sys_t *sys,
> mtime_t *delay )
>
>  static HRESULT StreamTimeGet( aout_stream_t *s, mtime_t *delay )
>  {
> -    return TimeGet( s->sys, delay );
> +    return (TimeGet( s->sys, delay ) == DS_OK) ? 0 : -1;
>  }

It should be utterly obvious but please don't use numeric literals for 
HRESULT.

>  static int OutputTimeGet( audio_output_t *aout, mtime_t *delay )

-- 
Rémi Denis-Courmont