[vlc-devel] [PATCH] mmdevice: don't hard crash when CoInitializeEx fails on Start, show the reason

[Rémi Denis-Courmont]

Le 2015-03-18 13:26, Steve Lhomme a écrit :
> On Wed, Mar 18, 2015 at 11:24 AM, Rémi Denis-Courmont
> <remi at remlab.net> wrote:
>> Le 2015-03-18 13:13, Steve Lhomme a écrit :
>>>
>>> Maybe you can tell us why ?
>>
>>
>> It's obvious. We don't return errors on bugs, we abort.
>
> And it is wrong.

Intrinsically, returning an error on UB makes no sense. I don't get to 
decide on that, nor do you.

We could just ignore the error. But abort() makes it easier to debug.

>> Plus your attitude is not really conductive of motivating detailed 
>> reviews.
>
> Irrelevant.

Oh it is very relevant. It shows once again how you have zero 
considerations for volunteer(s) and the time they waste reviewing your 
patches. This is unacceptable especially from a paid developper. Maybe 
you would be more considerate if I charged 80€ the hour payable in 
advance for code review "consulting services"?

-- 
Rémi Denis-Courmont