[vlc-devel] [PATCH 1/1] udp: adjust receive buffer for windows 7 and earlier

[Rémi Denis-Courmont]

Le 2015-03-19 12:50, Jean-Baptiste Kempf a écrit :
> On 19 Mar, Ilkka Ollakka wrote :
>> On Thu, Mar 19, 2015 at 10:36:09AM +0100, Jean-Baptiste Kempf wrote:
>> > On 19 Mar, Ilkka Ollakka wrote :
>> > > Try to detect runtime our windows version.
>>
>> > Detecting Windows version per number, with GetVersionEx is not
>> > recommended, and will warn the certification WACK.
>>
>> > Why don't you do it for all Windows version?
>> > Windows 8 and Windows 10 don't need it?
>>
>> Yes, seems that Windows 8 and forward handle it correctly and don't 
>> need
>> this.
>
> But does it hurt if you call this?

Yes. Newer IP stacks deal with buffering better than setsockopt().

-- 
Rémi Denis-Courmont