[vlc-devel] [PATCH] ttml.c : Added parsing of time and displaying subtitle

[Jean-Baptiste Kempf]

Hello,


On 23 Mar, Sushma Reddy wrote :
> Subject: [PATCH] Added parsing for subtitle with time and displaying
> subtiles

I'm not sure it's really for this mailing list, but thanks.

> + case DEMUX_GET_TIME:
> + pi64 = (int64_t*)va_arg( args, int64_t * );
> + if(p_sys->i_length)
> + *pi64 = p_sys->subtitle[p_sys->i_subtitle].i_start;
> + return VLC_SUCCESS;
> + return VLC_EGENERIC;

Be careful about your indentation.

> -        {
> +        {
>              const char* psz_text = NULL;
> +    int i_len = 0;
> +     subtitle_t *p_subtitle = &p_sys->subtitle[p_sys->i_subtitle];
> +    p_subtitle = malloc (sizeof(subtitle_t));

Same here.

> -
> +    msg_Dbg(p_demux,"debuging demux enter1");
>      p_demux->pf_demux = Demux;
>      p_demux->pf_control = Control;
> 
> @@ -170,6 +227,7 @@ static int Open( vlc_object_t* p_this )
>      p_sys->p_es = es_out_Add( p_demux->out, &fmt );
>      es_format_Clean( &fmt );
> 
> +msg_Dbg(p_demux,"debuging open enter2");
>      /* Initialize things here */

Debug messages should not be on a commit.

With my kindest regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device