[vlc-devel] Regression in loading subtitles from samba share on windows platform

[Zoran Turalija]

When accessing movie from samba share with vlc for windows using UNC path,
subtitles that are located in same samba share path as movie is, are working
on vlc x64 nightlies build from 20150303, but not on build from 20150304.
Movie is being played just fine in both cases, except there is an error while
loading subtitle in later case.

Could not reproduce problem on linux, due to different method used on linux
to access samba shared resources and I have no idea how to force direct use
of UNC path on linux either (is that even possible?). And as I don't have
vlc_for_windows build testbed to do a proper git bisect, compile and test,
I can't be 100% sure about culprit nor suggest proper resolution for this
regression.

Looks like this commit may have introduced regression:

  vlc_path2uri: allow file names starting with a pair of backslashes
  http://git.videolan.org/?p=vlc.git;a=commit;h=84ea87f354ce88a9e86c259424027578f0c3252d

>From debug log, it looks like last letter of server name gets truncated at
some point during conversion from UNC to url path form:

...
core debug: Buffering 0%
mkv debug: Starting the UI Hook
core debug: using demux module "mkv"
core debug: looking for a subtitle file in \\multimedia\videos\FOR TESTING\
core debug: autodetected subtitle: \\multimedia\videos\FOR TESTING\\tears.of.steel.english.srt with priority 3
core debug: `file://multimedi/videos/FOR%20TESTING//tears.of.steel.english.srt' gives access `file' demux `' path `multimedi/videos/FOR%20TESTING//tears.of.steel.english.srt'
core debug: creating demux: access='file' demux='subtitle' location='multimedi/videos/FOR%20TESTING//tears.of.steel.english.srt' file='\\multimedi\videos\FOR TESTING\\tears.of.steel.english.srt'
core debug: looking for access_demux module matching "file": 13 candidates
core debug: auto hiding mouse cursor
core debug: no access_demux modules matched
core debug: creating access 'file' location='multimedi/videos/FOR%20TESTING//tears.of.steel.english.srt', path='\\multimedi\videos\FOR TESTING\\tears.of.steel.english.srt'
core debug: looking for access module matching "file": 21 candidates
filesystem debug: opening file `\\multimedi\videos\FOR TESTING\\tears.of.steel.english.srt'
filesystem error: cannot open file \\multimedi\videos\FOR TESTING\\tears.of.steel.english.srt (No such file or directory)
core debug: no access modules matched
core error: open of `file://multimedi/videos/FOR%20TESTING//tears.of.steel.english.srt' failed
core debug: looking for decoder module matching "any": 44 candidates
avcodec debug: CPU flags: 0x000011db
...

-- 
Kind regards,
Zoran Turalija