[vlc-devel] [vlc-commits] contrib/ebml+mkv: compile with hidden symbols

[Sean McGovern]

While we are at it, would it be OK to start building these 2 contribs with C++ exceptions disabled? VLC dies a fiery death when I feed it a broken Matroska file right now.

At least on my Solaris box anyhow. I haven't been able to reproduce the SEGV on Linux or Win64.

-- Sean McG.

-----Original Message-----
From: Steve Lhomme <robux4 at gmail.com>
Sender: "vlc-devel" <vlc-devel-bounces at videolan.org>Date: Mon, 4 May 2015 08:46:22 
To: Mailing list for VLC media player developers<vlc-devel at videolan.org>
Reply-To: Mailing list for VLC media player developers <vlc-devel at videolan.org>
Subject: Re: [vlc-devel] [vlc-commits] contrib/ebml+mkv: compile with hidden
	symbols

What was the error when this wasn't set ? I'd like to fix this in the
original libraries so the patch is not needed anymore.

On Thu, Apr 30, 2015 at 8:34 PM, Felix Paul Kühne <git at videolan.org> wrote:
> vlc/vlc-2.2 | branch: master | Felix Paul Kühne <fkuehne at videolan.org> | Sat Jan 24 23:53:59 2015 +0100| [5c5cd0c3d6ab5aedc909ea0d2ebde3d74ed7cff4] | committer: Felix Paul Kühne
>
> contrib/ebml+mkv: compile with hidden symbols
>
> This solves linking issues on iOS and should have no negative impact on further platforms
>
> (cherry picked from commit 6031c9769a0dbd8a4f484027d5856b12ec9cc188)
>
>> http://git.videolan.org/gitweb.cgi/vlc/vlc-2.2.git/?a=commit;h=5c5cd0c3d6ab5aedc909ea0d2ebde3d74ed7cff4
> ---
>
>  contrib/src/ebml/rules.mak     |    4 ++--
>  contrib/src/matroska/rules.mak |    4 +++-
>  2 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/contrib/src/ebml/rules.mak b/contrib/src/ebml/rules.mak
> index 9d87c29..4a5ac16 100644
> --- a/contrib/src/ebml/rules.mak
> +++ b/contrib/src/ebml/rules.mak
> @@ -14,10 +14,10 @@ libebml: libebml-$(EBML_VERSION).tar.bz2 .sum-ebml
>         $(MOVE)
>
>  # libebml requires exceptions
> -EBML_EXTRA_FLAGS = CXXFLAGS="${CXXFLAGS} -fexceptions" \
> +EBML_EXTRA_FLAGS = CXXFLAGS="${CXXFLAGS} -fexceptions -fvisibility=hidden" \
>                                         CPPFLAGS=""
>
>  .ebml: libebml
> -       cd $< && $(HOSTVARS) ./configure $(HOSTCONF)
> +       cd $< && $(HOSTVARS) ./configure $(HOSTCONF) $(EBML_EXTRA_FLAGS)
>         cd $< && $(MAKE) install
>         touch $@
> diff --git a/contrib/src/matroska/rules.mak b/contrib/src/matroska/rules.mak
> index b8d0165..c71ee83 100644
> --- a/contrib/src/matroska/rules.mak
> +++ b/contrib/src/matroska/rules.mak
> @@ -16,7 +16,9 @@ libmatroska: libmatroska-$(MATROSKA_VERSION).tar.bz2 .sum-matroska
>         $(UNPACK)
>         $(MOVE)
>
> +MATROSKA_EXTRA_FLAGS = CXXFLAGS="${CXXFLAGS} -fvisibility=hidden"
> +
>  .matroska: libmatroska
> -       cd $< && $(HOSTVARS) ./configure $(HOSTCONF)
> +       cd $< && $(HOSTVARS) ./configure $(HOSTCONF) $(MATROSKA_EXTRA_FLAGS)
>         cd $< && $(MAKE) install
>         touch $@
>
> _______________________________________________
> vlc-commits mailing list
> vlc-commits at videolan.org
> https://mailman.videolan.org/listinfo/vlc-commits
_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
https://mailman.videolan.org/listinfo/vlc-devel