[vlc-devel] [PATCH 6/8] access/directory: remove recursive code

[Thomas Guillem]

On Thu, May 7, 2015, at 14:01, Rémi Denis-Courmont wrote:
> Le 2015-05-07 13:10, Thomas Guillem a écrit :
> > -#ifdef HAVE_OPENAT
> > -/* Detect directories that recurse into themselves. */
> > -static bool has_inode_loop (const directory *dir, dev_t dev, ino_t 
> > inode)
> > -{
> > -    while (dir != NULL)
> > -    {
> > -        if ((dir->device == dev) && (dir->inode == inode))
> > -            return true;
> > -        dir = dir->parent;
> > -    }
> > -    return false;
> > -}
> > -#endif
> 
> I can't really see where the inode loop checks is after this patch.

Ah yes, good catch, It was already broken by my patch that removed
recursivity for this access.
The same kind of issue can happen with others accesses like http (when
readdir will be implemented).

The main issue is that we never save the items we send from the
preparser or the demux directory. So, maybe, a patch should be done
somewhere in the playlist, I'll look into it.



> 
> -- 
> Rémi Denis-Courmont
> Remlab T:mi
> http://www.remlab.net/
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel