[vlc-devel] [PATCH] Dim MacBook keyboard backlight during video playback on OSX
max at maxmouchet.com
Fri May 8 20:47:44 CEST 2015
> On 08 May 2015, at 18:35, David Fuhrmann <david.fuhrmann at gmail.com> wrote:
> Hello Maxime,
> Thanks for this cool patch. Does this work with all supported OS X versions (>= 10.6)?
> Generally, did you consider only dimming the light when the VLC video is in fullscreen mode? Because in windowed mode, the rest of the monitor will probably so bright that it does not really make sense to dim the keyboard (and maybe the user wants to use it still).
> Please also see some minor remarks about your patch inline.
Thanks for the comments. It should work, the IOKit methods used are supported since 10.5.
Indeed, it makes sense. Actually I got the idea while watching a video in fullscreen !
I’ll make the necessary changes. By the way, what is the proper way to send an edited patch to the mailing list ? Should I use git send-email with the same commit log text ?
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the vlc-devel