[vlc-devel] [PATCH 2/2] audio_filter: SOFAlizer new module (GUI)

[Wolfgang Hrauda]

Thanks, Francois. I just posted updated patches of SOFAlizer (as of May 12th). Please check them out.
Best,
Wolfgang


Am 14.04.2015 um 18:14 schrieb Francois Cartegnie <fcvlcdev at free.fr>:

> Le 16/02/2015 13:28, Wolfgang Hrauda a écrit :
> 
>> +Sofalizer::Sofalizer( intf_thread_t *p_intf, QWidget *parent )
>> +    : AudioFilterControlWidget( p_intf, parent, "sofalizer" )
>> +{
>> +    i_smallfont = -1;
>> +    const FilterSliderData::slider_data_t a[6] =
>> +    {
>> +        { "sofalizer-select",   qtr("Select File"),    qtr(""), 1.0f, 3.0f, 1.0f, 1.0f, 1.0f },
> 
> Using qtr() without understanding
Agreed, I changed its usage to be consistent with the rest of the file.

> 
>> +        { "sofalizer-gain",   qtr("Gain"),    qtr("dB"), -20.0f, 40.0f, 0.0f, 1.0f, 1.0f },
>> +        { "sofalizer-switch",   qtr("Switch"),    qtr(""), 0.0f , 4.0f, 0.0f, 1.0f, 1.0f },
>> +        { "sofalizer-rotation",  qtr("Rotation"),   "Deg", -180.0f, 180.0f, 0.0f, 1.0f, 1.0f },
>> +        { "sofalizer-elevation",  qtr("Elevation"),   "Deg", -90, 90, 0, 1.0f, 1.0f },
>> +        { "sofalizer-radius",  qtr("Radius"),   "m", 0.1f , 2.1f, 1.0f, 0.1f, 1.0f },
>> +    };
>> +    for( int i=0; i<6 ;i++ ) controls.append( a[i] );
>> +    build();
>> +}
>> +
> 
>> +    audioTab->addTab( sofalizer, qtr( "SOFAlizer" ) );
> 
> no i10n
I agree this one does not really need i18n. However, i18n is also used with the “Equalizer” audio module which, I guess, also doesn't need i18n. So I wonder whether I should really remove this?
BTW: It's either “i18n” (internalization) or “l10n” (localization). ;-).


> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20150512/bfb63153/attachment.html>