[vlc-devel] [vlc-commits] codec: avcodec: assert provides no safety

[Francois Cartegnie]

Le 16/05/2015 15:55, Rémi Denis-Courmont a écrit :
> Le samedi 16 mai 2015, 15:26:41 Francois Cartegnie a écrit :
>> vlc | branch: master | Francois Cartegnie <fcvlcdev at free.fr> | Sat May 16
>> 15:24:55 2015 +0200| [c5d61dbf0f53fcc753f47eae7ccfe53767571b35] |
>> committer: Francois Cartegnie
>>
>> codec: avcodec: assert provides no safety
> 
> And? Adding an if statement in undefined behaviour does not provide safety 
> either.
> 

I don't see the point.

Handling that bogus consumed bytes you have to blacklist faulty avcodec
version prior decoding, or allow p_block->i_buffer to overflow in
releases and its consequences.

Francois