[vlc-devel] [PATCH 4/6] mediacodec: GetOutput: separate JNI part from Decoder part

Jean-Baptiste Kempf jb at videolan.org
Tue May 19 21:43:35 CEST 2015


On 19 May, Thomas Guillem wrote :
> -        int width           = GET_INTEGER(format, "width");
> -        int height          = GET_INTEGER(format, "height");
> -        p_sys->stride       = GET_INTEGER(format, "stride");
> -        p_sys->slice_height = GET_INTEGER(format, "slice-height");
> -        p_sys->pixel_format = GET_INTEGER(format, "color-format");
> -        int crop_left       = GET_INTEGER(format, "crop-left");
> -        int crop_top        = GET_INTEGER(format, "crop-top");
> -        int crop_right      = GET_INTEGER(format, "crop-right");
> -        int crop_bottom     = GET_INTEGER(format, "crop-bottom");
> +        p_out->type = MC_OUT_TYPE_CONF;
> +        p_out->u.conf.width = GET_INTEGER(format, "width");
> +        p_out->u.conf.height = GET_INTEGER(format, "height");
> +        p_out->u.conf.stride = GET_INTEGER(format, "stride");
> +        p_out->u.conf.slice_height = GET_INTEGER(format, "slice-height");
> +        p_out->u.conf.pixel_format = GET_INTEGER(format, "color-format");
> +        p_out->u.conf.crop_left = GET_INTEGER(format, "crop-left");
> +        p_out->u.conf.crop_top = GET_INTEGER(format, "crop-top");
> +        p_out->u.conf.crop_right = GET_INTEGER(format, "crop-right");
> +        p_out->u.conf.crop_bottom = GET_INTEGER(format, "crop-bottom");

It was better when = was aligned :)

The rest LGTM.

With my kindest regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device



More information about the vlc-devel mailing list