[vlc-devel] [PATCH 5/6] mediacodec: add JNI submodule

Jean-Baptiste Kempf jb at videolan.org
Tue May 19 21:48:49 CEST 2015

On 19 May, Thomas Guillem wrote :
> +#define MC_API_TEXT N_("MediaCodec API")
> +#define MC_API_LONGTEXT N_("Access MediaCodec via jni or via ndk")

No. You do not need that translated. Or even as an option.

> +typedef struct vlc_mc vlc_mc;
> +typedef struct vlc_mc_sys vlc_mc_sys;
> +typedef struct vlc_mc_out vlc_mc_out;

Quite bad names, IMHO.

Rest LGTM.

With my kindest regards,

Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device

More information about the vlc-devel mailing list