[vlc-devel] [PATCH v2 1/3] os2: thread: improve vlc_poll_os2()

[KO Myung-Hun]

Rémi Denis-Courmont wrote:
> On Saturday 31 October 2015 16:41:24 KO Myung-Hun wrote:
>> Rémi Denis-Courmont wrote:
>>> Le 2015-10-29 15:28, KO Myung-Hun a écrit :
>>>> Rémi Denis-Courmont wrote:
>>>>> On Sunday 25 October 2015 22:01:34 KO Myung-Hun wrote:
>>>>>> From: KO Myung-Hun <komh78 at gmail.com>
>>>>>>
>>>>>> If non-sockets, set revents to POLLNVAL;
>>>>>
>>>>> Are sockets file descriptors? If so, I don´t see any reasons why your
>>>>> poll()
>>>>> cannot handle regular file descriptors correctly.
>>>>
>>>> Sockets are file descriptors. However, select() does not support other
>>>> file descriptors such as regular files than sockets.
>>>
>>> Then there are no reasons not to support regular files in the poll()
>>> replacement.
>>
>> Then do you mean that regular files should not be POLLNVAL ? And it's ok
>> that they are treated as being ready for all modes ?
> 
> Yes.
> 
>> Finally, compat/poll.c on Win32 supports regular files correctly ?
> 
> Socekts are *not* file descriptors on Windows. We can´t do that on Windows.
> 

Updated.

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-os2-thread-improve-vlc_poll_os2.patch
Type: application/x-patch
Size: 4026 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20151101/caa35b5c/attachment.bin>