[vlc-devel] [RFC PATCH 0/3] drain aout filters
thomas at gllm.fr
Tue Nov 3 15:40:59 CET 2015
On Tue, Nov 3, 2015, at 14:36, Rémi Denis-Courmont wrote:
> Le 2015-11-03 14:39, Thomas Guillem a écrit :
> > The first 2 patches change the behavior of pf_audio_filter: if the
> > input block
> > is NULL, then the filter is draining (same behavior than pf_decode
> > when input
> > is NULL). An other solution is to add pf_audio_drain, that way, we
> > don't have
> > to modify every audio filters (but then, the behavior will be
> > different than
> > pf_decode).
> Yes, I'd have added a drain call given that it is less "invasive" and
> there is a (video) flush call already. But it's a matter of taste.
Finally I chose to add a flush and drain call. Indeed, the large
majority of filters won't need to drain/flush, so it's better to keep
the current behavior of pf_audio_filter untouched.
> Rémi Denis-Courmont
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
More information about the vlc-devel