[vlc-devel] [PATCH v2] Add support for GoPro HiLight tags as chapters, so they can appear in the progress bar

[Francois Cartegnie]

Le 08/11/2015 18:36, Emeric Grange a écrit :
> ---
>  modules/demux/mp4/libmp4.c | 39 +++++++++++++++++++++++++++++++++++++++
>  modules/demux/mp4/libmp4.h | 14 ++++++++++++++
>  modules/demux/mp4/mp4.c    | 24 ++++++++++++++++++++++++
>  3 files changed, 77 insertions(+)

I don't want to drive you into despair,
but you didn't address any of the previous issues regarding the
overflows, and you introduced a new off by one.

Anything that arrives to a demuxer must not be trusted.

Francois