[vlc-devel] [RFC PATCH] decoder: do not depend on allocated block for flush

Rémi Denis-Courmont remi at remlab.net
Wed Nov 18 19:22:44 CET 2015

On Wednesday 18 November 2015 18:24:42 Thomas Guillem wrote:
> With this patch, a flush won't fail because of a block_Alloc failure.

I imagined a constant static block before, but gave up due to concerns about 
p_next or other block_t fields being potentially modified. Storing the flush 
block per decoder is an innovative trick to partly alleviates the problem. I 
am not certain that there are no corner cases where the block would end up 
being used more than once concurrently still.

I think we would be better off with explicit flush callbacks.

Rémi Denis-Courmont

More information about the vlc-devel mailing list