[vlc-devel] [PATCH] [RFC] input: set "input-current" early so control interfaces can control earlier

[Steve Lhomme]

On Mon, Nov 23, 2015 at 6:17 PM, Rémi Denis-Courmont <remi at remlab.net> wrote:
> Le 2015-11-23 20:11, Steve Lhomme a écrit :
>>
>> On Mon, Nov 23, 2015 at 3:06 PM, Rémi Denis-Courmont <remi at remlab.net>
>> wrote:
>>>
>>> Le 2015-11-23 16:42, Steve Lhomme a écrit :
>>>>
>>>>
>>>> Also the way the input thread is currently done, it initializes its
>>>> "chain" (sout or vout/aout) right at the beginning.
>>>
>>>
>>>
>>> That is _not_ going to change. Too many features depend on this.
>>
>>
>> This is not what this patch is about, no worries.
>>
>>>> It may be done
>>>> before input_Start() finishes, and thus PlayItem is done. So we need
>>>> at least to have this sout decision done at the beginning of the input
>>>> thread. It could be some kind of "input modifier" plugin, if we don't
>>>> want to abuse the control interface too much.
>>>
>>>
>>>
>>> That is also not going to change: the whole point of the (otherwise
>>> crappy)
>>> VLC playlist is multiple interfaces/views. If you want full control over
>>> an
>>
>>
>> What do you mean ? That the playlist allows multiple interfaces/UIs to
>> have access to it ?
>
>
> I mean...
>
>> - can add a custom sout depending on the input being played. For now
>> it may be forcing the sout, rather than adding one more.
>
>
> ...that. You don't need to do that if you own the input, and you can't do
> that if you use the playlist (because multiple interfaces would conflict
> with one another).

But one of the goals of the Chromecast is to serve as an output for
whatever you play in your regular VLC. And that playback happens via
the playlist. We don't want to create a secondary player or UI (with a
list of files to play) just for that.

What do you mean conflict with each other ? What kind of things are
control interfaces allowed to do and not do ? And if some things are
not allowed for such modules, maybe we need a different kind of
control module ?

For example if you launch VLC with a sout in the command-line and then
set a sout in the GUI, who wins ? How is that different that selecting
a Chromecast for playback from the GUI, rather than a sout in the
wizard ?

>> - define this sout before or during the Init call of the
>> input_thread_t. After that the "sout" variable won't be used. That
>> leaves room between input_Create() and Init() to do it (both
>> included). That's compatible with libvlc and the playlist based
>> playback.
>
>
> Same problem.
>
>
> --
> Rémi Denis-Courmont
> http://www.remlab.net/
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel