[vlc-devel] [PATCH] [RFC] input: set "input-current" early so control interfaces can control earlier

Rémi Denis-Courmont remi at remlab.net
Tue Nov 24 10:47:25 CET 2015


   Hello,

Le 2015-11-24 10:55, Steve Lhomme a écrit :
>> Could you, like, look around the code base to answer your own 
>> questions? I
>> have much more interesting things to do with my free time than code 
>> review and
>> architectural documentation.
>
> The problem is that if I hit unwritten rules, I have no way to find
> beforehand.

That was not strictly an unwritten rule, and it is even less of an 
unwritten rule now.

And I don't think it is even relevant. In a professional setting, my 
reviews (in general) would have been utterly inadequate regardless of 
the would-be quality of the documentation.  But that is not a 
professional setting, at least not for me. I have already spent/wasted 
far more time and energy than I would want on this topic, as well as on 
reviews in general.

-- 
Rémi Denis-Courmont
http://www.remlab.net/


More information about the vlc-devel mailing list