[vlc-devel] [PATCH 1/4] add vlc_keystore API
remi at remlab.net
Thu Nov 26 13:34:52 CET 2015
Le 2015-11-26 14:11, Felix Paul Kühne a écrit :
>> On 26 Nov 2015, at 11:39, Thomas Guillem <thomas at gllm.fr> wrote:
>> On Wed, Nov 25, 2015, at 20:13, Rémi Denis-Courmont wrote:
>>> On Wednesday 25 November 2015 19:14:25 Thomas Guillem wrote:
>>>> + * Remove entries that match a dictionary
>>>> + *
>>>> + * @param p_keystore keystore object
>>>> + * @param p_dict dictionary
>>>> + *
>>>> + * @return number of entries removed
>>>> + */
>>>> +VLC_API unsigned int
>>>> +vlc_keystore_dict_remove(vlc_keystore *p_keystore,
>>>> + const vlc_dictionary_t *p_dict);
>>> While I would agree that a key store API should support deleting
>>> manually, I doubt that it will be:
>>> 1/ accessible/useful in VLC,
>>> 2/ universally supported by all back-ends.
>>> That would rather seem to belong in the password manager
>> Yes, I hesitated too for this one, but I thought maybe we'll add a
>> libvlc_keystore api to use this function.
> I’d like to mention here that libvlc supports operating systems which
> do not have a password manager application, nor would it be
> technically feasible to develop one as there can be one crypto
> (key ring, keychain, …) per application sandbox.
I fail to see the link.
> Therefore, I would love to be able to provide the ability to the user
> to delete authentication credentials stored within the VLC context.
I would hate to break other apps because the user deleted shared creds.
Besides, without a listing function, deletion is pretty useless (and I
don't want a useless listing function either).
More information about the vlc-devel