[vlc-devel] [PATCH 3/4] keystore: add libsecret keystore module

[Rémi Denis-Courmont]

Le 2015-11-26 22:46, Thomas Guillem a écrit :

>> > This won't be used by an user interface thread.
>>
>> This module is used from the input thread that as an interruptible
>> context, right ?

That would depend on the implementation. I would expect that the key 
store is used by the login dialog, especially if you still plan to 
support multiple credentials per resources. IIRC, the Qt dialog provider 
runs on the Qt UI thread.

>> If I can use and expose vlc_threadvar_get(vlc_interrupt_var),
>> vlc_interrupt_prepare, and vlc_interrupt_finish in vlc_interrupt.h, 
>> I
>> could set up a callback that cancel all these sync functions (via a
>> Cancellable that can be passed to all sync functions).

I have never used GCancellable. Given from the Glib doc, it looks like 
it would work. I have been reluctant to expose the low-level interrupt 
support because of nonobvious locking constraints. It seems prone to 
lock inversion bugs.

> Or I can use secret_service_*_async functions, a semaphore and
> vlc_sem_wait_i11e.

I don't know how those work. It might be tricky if you need a Glib main 
loop.

-- 
Rémi Denis-Courmont
http://www.remlab.net/