[vlc-devel] [PATCH 2/3] vout: pause and resume the decoder pool

[Thomas Guillem]

On Fri, Nov 27, 2015, at 16:03, Rémi Denis-Courmont wrote:
> Le 2015-11-26 21:03, Thomas Guillem a écrit :
> > This fixes a deadlock when a decoder waits for a new picture while
> > it's pausing
> 
> How is that a deadlock? Does it not unblock just fine when resuming?

No, it deadlocks on flush/close since the decoder thread wait for an
other thread that wait for a new picture, picture that will never come
since we are paused.

> 
> > or flushing in a paused state.
> 
> It sounds like we have too few pictures in the pool if this happens. 
> Maybe flushing the video output *also* before the decoder fixes it??

I tried to flush before instead of after, but it wasn't working. I
didn't think about your solution. It seems to work fine and it's way
simper than my solution. I'll propose a patch, thanks!

> 
> -- 
> Rémi Denis-Courmont
> http://www.remlab.net/
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel