[vlc-devel] [PATCH v3 00/10] Introducing 15- and 31-band ISO equalizers

[Jean-Baptiste Kempf]

On 29 Nov, Ronald Wright wrote :
> This set of patches is an update of last year's patch set that introduces
> improvements to the equalizer code, which include 15- and 31-band ISO
> equalizers.

That's a great addition :)

> Currently, the extra equalizers can only be loaded from the desktop Qt
> interface, since I have close to no experience in OS X development, and the
> goal of LibVLC is to keep the API as simple as possible.  However, the code for

Don't worry about Qt, seriously :)

> Ronald Wright (10):
>   Add monotone cubic interpolation support
>   Add utilities for parsing equalizer band strings
>   Add test for monotone cubic interpolation support
>   Add test for equalizer band string parsing utilities

You should reorder :)

>   equalizer: Add support for extra sets of ISO bands

Yes, but be careful about our i10n.

>  create mode 100644 include/vlc_eqz_util.h

We have completion, you know. vlc_equalizer.h is fine.

>  24 files changed, 2366 insertions(+), 261 deletions(-)

\o/ Excellent job!

With my kindest regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device