[vlc-devel] [PATCH] rdp: Fix build with FreeRDP 2.0.0.

[Jean-Baptiste Kempf]

On 30 Nov, Vinson Lee wrote :
> Signed-off-by: Vinson Lee <vlee at freedesktop.org>


Fails to compile.

  CC       access/librdp_plugin_la-rdp.lo
../../modules/access/rdp.c: In function ‘postConnectHandler’:
../../modules/access/rdp.c:240:100: warning: "FREERDP_MINOR_VERSION" is
not defined [-Wundef]
 #if defined(FREERDP_VERSION_MAJOR) && (FREERDP_VERSION_MAJOR > 1 ||
(FREERDP_VERSION_MAJOR == 1 && FREERDP_MINOR_VERSION >= 1))
                                                                                                    ^
In file included from ../../include/vlc_common.h:896:0,
                 from ../../modules/access/rdp.c:29:
../../modules/access/rdp.c:245:34: error: ‘rdpSettings {aka struct
rdp_settings}’ has no member named ‘width’
              p_instance->settings->width,
                                  ^
../../include/vlc_messages.h:78:23: note: in definition of macro
‘msg_Generic’
             __func__, __VA_ARGS__)
                       ^
../../modules/access/rdp.c:239:5: note: in expansion of macro ‘msg_Dbg’
     msg_Dbg( p_vlccontext->p_demux, "connected to desktop %dx%d (%d
bpp)",
     ^
../../modules/access/rdp.c:246:34: error: ‘rdpSettings {aka struct
rdp_settings}’ has no member named ‘height’
              p_instance->settings->height,
                                  ^
../../include/vlc_messages.h:78:23: note: in definition of macro
‘msg_Generic’
             __func__, __VA_ARGS__)
                       ^
../../modules/access/rdp.c:239:5: note: in expansion of macro ‘msg_Dbg’
     msg_Dbg( p_vlccontext->p_demux, "connected to desktop %dx%d (%d
bpp)",
     ^
../../modules/access/rdp.c:247:34: error: ‘rdpSettings {aka struct
rdp_settings}’ has no member named ‘color_depth’
              p_instance->settings->color_depth
                                  ^
../../include/vlc_messages.h:78:23: note: in definition of macro
‘msg_Generic’
             __func__, __VA_ARGS__)
                       ^
../../modules/access/rdp.c:239:5: note: in expansion of macro ‘msg_Dbg’
     msg_Dbg( p_vlccontext->p_demux, "connected to desktop %dx%d (%d
bpp)",
     ^
../../modules/access/rdp.c: In function ‘Open’:
../../modules/access/rdp.c:448:35: warning: assignment from incompatible
pointer type [-Wincompatible-pointer-types]
     p_sys->p_instance->PreConnect = preConnectHandler;
                                   ^
../../modules/access/rdp.c:449:36: warning: assignment from incompatible
pointer type [-Wincompatible-pointer-types]
     p_sys->p_instance->PostConnect = postConnectHandler;
                                    ^
../../modules/access/rdp.c:450:37: warning: assignment from incompatible
pointer type [-Wincompatible-pointer-types]
     p_sys->p_instance->Authenticate = authenticateHandler;
                                     ^
Makefile:15755: recipe for target 'access/librdp_plugin_la-rdp.lo'
failed


-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device