[vlc-devel] [PATCH v3 02/10] Add utilities for parsing equalizer band strings

[Ron Wright]

On 11/30/2015 02:42 AM, Jean-Baptiste Kempf wrote:
> On 29 Nov, Ronald Wright wrote :
>> Note:  This patch cannot be applied until after patch 1 is applied.
> How so?

This is because patch 1 provides interpolation functions, and this patch 
uses them.

>> -TESTS = $(check_PROGRAMS) check_symbols
>> +TESTS = $(check_PROGRAMS)
> No.
>
>>   test_block_SOURCES = test/block_test.c
>>   test_block_LDADD = $(LDADD) $(LIBS_libvlccore)
>> @@ -594,7 +596,7 @@ stamp-revision:
>>   # Unit/regression test
>>   ###############################################################################
>>   
>> -dist_check_SCRIPTS = check_headers check_symbols
>> +dist_check_SCRIPTS = check_headers
> No.
>
>>   
>>   check-local:
>>   	for h in `echo $(pkginclude_HEADERS) | sed -e s,\.\./include/,,g`; \
>> diff --git a/src/libvlccore.sym b/src/libvlccore.sym
>> index f03e451..134f031 100644
>> --- a/src/libvlccore.sym
>> +++ b/src/libvlccore.sym
>> @@ -66,6 +66,7 @@ config_ResetAll
>>   config_SaveConfigFile
>>   config_StringEscape
>>   config_StringUnescape
>> +convert_xml_special_chars
>>   date_Change
>>   date_Decrement
>>   date_Get
>> @@ -87,6 +88,8 @@ decoder_SynchroNewPicture
>>   decoder_SynchroRelease
>>   decoder_SynchroReset
>>   decoder_SynchroTrash
>> +decode_URI
>> +decode_URI_duplicate
>>   demux_Delete
>>   demux_PacketizerDestroy
>>   demux_PacketizerNew
>> @@ -103,12 +106,15 @@ dialog_Question
>>   dialog_Register
>>   dialog_Unregister
>>   dialog_VFatal
>> +encode_URI_component
>>   EndMD5
>> +EnsureUTF8
>>   es_format_Clean
>>   es_format_Copy
>>   es_format_Init
>>   es_format_InitFromVideo
>>   es_format_IsSimilar
>> +filename_sanitize
>>   filter_Blend
>>   filter_chain_AppendFilter
>>   filter_chain_AppendFromString
>> @@ -228,6 +234,7 @@ input_Stop
>>   input_vaControl
>>   input_Close
>>   intf_Create
>> +IsUTF8
>>   libvlc_InternalAddIntf
>>   libvlc_InternalPlay
>>   libvlc_InternalCleanup
>> @@ -241,10 +248,7 @@ libvlc_ArtRequest
>>   vlc_UrlParse
>>   vlc_UrlClean
>>   vlc_path2uri
>> -vlc_uri2path
>> -vlc_uri_decode
>> -vlc_uri_decode_duplicate
>> -vlc_uri_encode
>> +make_path
>>   mdate
>>   module_config_free
>>   module_config_get
>> @@ -285,6 +289,7 @@ net_SetCSCov
>>   net_vaPrintf
>>   net_Write
>>   NTPtime64
>> +path_sanitize
>>   picture_BlendSubpicture
>>   picture_CopyPixels
>>   picture_Hold
>> @@ -358,6 +363,7 @@ playlist_VolumeSet
>>   playlist_VolumeUp
>>   playlist_MuteSet
>>   playlist_MuteGet
>> +resolve_xml_special_chars
>>   sdp_AddAttribute
>>   sdp_AddMedia
>>   secstotimestr
>> @@ -411,6 +417,7 @@ stream_ReadDir
>>   stream_FilterDefaultReadDir
>>   str_format_meta
>>   str_format_time
>> +str_duration
>>   subpicture_Delete
>>   subpicture_New
>>   subpicture_NewFromPicture
>> @@ -523,6 +530,9 @@ vlc_interpolant_create
>>   vlc_interpolant_destroy
>>   vlc_GetCPUCount
>>   vlc_CPU
>> +vlc_eqz_util_band_parser_destroy
>> +vlc_eqz_util_band_parser_init
>> +vlc_eqz_util_get_amp_array
>>   vlc_error
>>   vlc_event_attach
>>   vlc_event_detach
>> @@ -626,7 +636,6 @@ vlc_timer_create
>>   vlc_timer_destroy
>>   vlc_timer_getoverrun
>>   vlc_timer_schedule
>> -vlc_towc
>>   vlc_ureduce
>>   vlc_epg_Init
>>   vlc_epg_Clean
>> @@ -689,8 +698,6 @@ xml_Delete
>>   xml_ReaderCreate
>>   xml_ReaderDelete
>>   xml_ReaderReset
>> -vlc_xml_decode
>> -vlc_xml_encode
>>   vlc_keycode2str
>>   vlc_str2keycode
>>   fingerprinter_Create
> Clearly no.

Oops, sorry about that.  That might have happened because I was 
accidentally modifying an old libvlccore.sym file and an old Makefile.am 
file, which recently changed.  That was a mistake on my part.  I have 
attached an updated patch that fixes those mistakes. How does that look now?

Regards,

Ron Wright
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Add-utilities-for-parsing-equalizer-band-strings.patch
Type: text/x-patch
Size: 17443 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20151130/edd8b7b9/attachment.bin>