[vlc-devel] [PATCH 1/2] httpd: warn when an accept() failed even though it was signaled

Rémi Denis-Courmont remi at remlab.net
Mon Nov 30 18:11:57 CET 2015

On Monday 30 November 2015 18:07:49 Steve Lhomme wrote:
> On Mon, Nov 30, 2015 at 6:04 PM, Rémi Denis-Courmont <remi at remlab.net> 
> > On Monday 30 November 2015 18:01:28 Steve Lhomme wrote:
> >> But we only reach this code when we poll() that bound socket for
> >> POLLIN.
> > 
> > POLLERR and POLLHUP are *always* implicitly polled by specification.
> Yes, hence the other patch. I don't think we should accept on a socket
> that has errors or is disconnected. But then they should be closed
> properly. I might do another patch.

I think closing a listening socket on error is a rather obvious robustness and 
security problem.

Rémi Denis-Courmont

More information about the vlc-devel mailing list