[vlc-devel] [PATCH 1/5] Revert "decoder: flush the vout at exit"

Thomas Guillem thomas at gllm.fr
Mon Nov 30 19:14:02 CET 2015


On Mon, Nov 30, 2015, at 18:02, Rémi Denis-Courmont wrote:
> This reverts commit 09bb02031398361d6cd8868d82295b5e8c3f0bdc.
> ---
>  src/input/decoder.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/src/input/decoder.c b/src/input/decoder.c
> index 0f08198..70f22c2 100644
> --- a/src/input/decoder.c
> +++ b/src/input/decoder.c
> @@ -1761,14 +1761,6 @@ void input_DecoderDelete( decoder_t *p_dec )
>      vlc_mutex_lock( &p_owner->lock );
>      p_owner->b_waiting = false;
>      vlc_cond_signal( &p_owner->wait_request );
> -
> -    /* If the video output is paused or too slow, the decoded picture
> FIFO may
> -     * contain so many picture buffers that the decoder gets stuck
> waiting for
> -     * free buffers. Force all pending pictures in the decoder output
> FIFO
> -     * released to enable decoder forward progress - up to the thread
> -     * cancellation. */
> -    if( p_owner->p_vout != NULL )
> -        vout_Flush( p_owner->p_vout, VLC_TS_INVALID + 1 );
>      vlc_mutex_unlock( &p_owner->lock );
>  
>      vlc_join( p_owner->thread, NULL );

OK for 1-5,
I was wondering why the decoder took more than 1 seconds to close. 

> -- 
> 2.6.2
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list