[vlc-devel] [PATCH] Fixed pause issue for streams without end (live cameras)

[Paulo Vitor Magacho da Silva]

Hi,
The patch is to check only if the p_sys->rtsp is already created. That
should be enough to allow the video to be paused. Right now, both PAUSE and
SEEK have the same check and takes into account also the video duration,
which might be zero for live cameras.
Do you agree?
Thanks,

2015-10-04 5:00 GMT-03:00 Rémi Denis-Courmont <remi at remlab.net>:

> Le 2015-10-02 08:53, Paulo Vitor Magacho da Silva a écrit :
>
>> ---
>>  modules/access/live555.cpp | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/modules/access/live555.cpp b/modules/access/live555.cpp
>> index efd66f3..9d7b90e 100644
>> --- a/modules/access/live555.cpp
>> +++ b/modules/access/live555.cpp
>> @@ -1542,6 +1542,13 @@ static int Control( demux_t *p_demux, int
>> i_query, va_list args )
>>
>>          /* Special for access_demux */
>>          case DEMUX_CAN_PAUSE:
>> +            pb = (bool*)va_arg( args, bool * );
>> +            if( p_sys->rtsp )
>> +                *pb = true;
>> +            else
>> +                *pb = false;
>> +            return VLC_SUCCESS;
>> +
>>
>
> The bug seems real, but I do not understand how that will fix it.
> p_sys->rtsp is non-NULL if there is an RTSP session, regardless of the
> stream being live/seekable.
>
>
>          case DEMUX_CAN_SEEK:
>>              pb = (bool*)va_arg( args, bool * );
>>              if( p_sys->rtsp && p_sys->f_npt_length > 0 )
>>
>
> --
> Rémi Denis-Courmont
> http://www.remlab.net/
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20151004/afc1b8db/attachment.html>