[vlc-devel] [PATCH] Fixed pause issue for streams without end (live cameras)

Paulo Vitor Magacho da Silva pvmagacho at gmail.com
Tue Oct 6 12:07:14 CEST 2015


Actually the video being paused in a recorded video of a live camera. But
this stream does not return the end time.
Since there is no way of determining if a stream supports the PAUSE command
in RSTP 1.0, why check the end time? I don't think that removing the end
time check will cause anything to break.

2015-10-06 6:37 GMT-03:00 Rémi Denis-Courmont <remi at remlab.net>:

> Le 2015-10-05 14:06, Paulo Vitor Magacho da Silva a écrit :
>
>> In code both PAUSE and SEEK have the same check (p_sys->rtsp not NULL
>> and end time greater than 0).
>>
>
> I don't know any better ways to check for pause support in RTSP 1.0. IIRC,
> you need RTSP 2.0 to actually solve that problem.
>
> This is ok for SEEK where you want to
>> know the size of the video before jumping to another point.
>>
>
> That's not true. Without length, DEMUX_SET_POSITION makes no sense, but
> DEMUX_SET_TIME still does.
>
> But for pause there is no need to check for end time greater than 0.
>>
>
> Yes there is. If you tell VLC you can pause and you actually can't, bad
> stuff happens.
>
> And in live cameras (at lest for the one I am testing) this value is
>> zero preventing the camera to pause correctly.
>>
>
> Pausing live content makes no sense. You can't pause real time.
>
> I am aware that we pretend to support pause for some types live streams,
> but only insofar as it does not break anything (else).
>
> --
> Rémi Denis-Courmont
> http://www.remlab.net/
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20151006/49077b9b/attachment.html>


More information about the vlc-devel mailing list