[vlc-devel] [PATCH 1/2] win32: use if_nametoindex() from iphlpapi.h when available

Steve Lhomme robux4 at videolabs.io
Wed Oct 7 08:33:38 CEST 2015

On Tue, Oct 6, 2015 at 5:11 PM, Rémi Denis-Courmont <remi at remlab.net> wrote:
> If this is a PoC, it should say so.

What's a PoC ? Piece of Code ?

> Otherwise posting a patch that breaks make check is unacceptable.

"make check" doesn't build under Mingw64:

  CC       test/interrupt.o
../../../vlc/extras/package/win32/../../../src/test/interrupt.c: In
function 'test_thread_cancel':
error: implicit declaration of function 'pause'
../../../vlc/extras/package/win32/../../../src/test/interrupt.c: In
function 'main':
error: implicit declaration of function 'alarm'
It would require adding __USE_MINGW_ALARM and
__WINPTRHEAD_ENABLE_WRAP_API for a chance to build and potentially
breaking the real build.

> Next time, it's 7 days on my ignore list.
> --
> Rémi Denis-Courmont
> http://www.remlab.net/
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

More information about the vlc-devel mailing list