[vlc-devel] [PATCH] macosx: Remove wrong "Change" button behavior in simple shortcut prefs

epirat07 at gmail.com epirat07 at gmail.com
Wed Oct 7 20:18:29 CEST 2015

From: Marvin Scholz <epirat07 at gmail.com>

Remove the primary state of the "Change" button in the simple preferences
shotcut view, as the window already has a primary button, which is the one
to apply the settings. Having two buttons as primary buttons is bad UX
and very confusing as it's unclear which button will be triggered when
hitting the enter key.
Given that the "Change" button was not triggered by the enter key anyway,
this should not cause any app behavior changes.
 extras/package/macosx/Resources/English.lproj/SimplePreferences.xib | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/extras/package/macosx/Resources/English.lproj/SimplePreferences.xib b/extras/package/macosx/Resources/English.lproj/SimplePreferences.xib
index 8ce38d8..fda675e 100644
--- a/extras/package/macosx/Resources/English.lproj/SimplePreferences.xib
+++ b/extras/package/macosx/Resources/English.lproj/SimplePreferences.xib
@@ -1774,7 +1774,7 @@ Gw
                         <autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
                             <tableView verticalHuggingPriority="750" allowsExpansionToolTips="YES" alternatingRowBackgroundColors="YES" columnReordering="NO" multipleSelection="NO" emptySelection="NO" autosaveName="sprefs_hotkeys_view" headerView="3541" id="2670">
-                                <rect key="frame" x="0.0" y="0.0" width="528" height="19"/>
+                                <rect key="frame" x="0.0" y="0.0" width="528" height="286"/>
                                 <autoresizingMask key="autoresizingMask"/>
                                 <size key="intercellSpacing" width="3" height="2"/>
@@ -1841,9 +1841,6 @@ Gw
                     <buttonCell key="cell" type="push" title="Change" bezelStyle="rounded" alignment="center" borderStyle="border" inset="2" id="3526">
                         <behavior key="behavior" pushIn="YES" lightByBackground="YES" lightByGray="YES"/>
                         <font key="font" metaFont="system"/>
-                        <string key="keyEquivalent" base64-UTF8="YES">
                         <action selector="hotkeySettingChanged:" target="-2" id="ryh-Ni-dNC"/>

More information about the vlc-devel mailing list