[vlc-devel] [sout developers] VLC streaming violation of MPEG-TS discontinuity flag

[Jean-Paul Saman]

On Mon, Oct 5, 2015 at 9:32 AM, Jean-Paul Saman <jpsaman at videolan.org>
wrote:

> Ilkka,
>
> On Sat, Oct 3, 2015 at 8:17 PM, Ilkka Ollakka <ileoo at videolan.org> wrote:
>
>> On Fri, Sep 25, 2015 at 11:10:52AM +0200, Jean-Paul Saman wrote:
>>
>> > I read the specs basically the same as your understanding above.
>>
>> Hi Jean-Paul,
>>
>> I think you have patch with those small comment updates and typos that
>> we checked during vdd?
>>
>
> Yes I am working on it (testing, reviewing etc). Should be done this week.
>

It took a little longer, but here are patches:

The following logic has been used in the patches:

+ decoders :
   - reset timeline on BLOCK_FLAG_DISCONTINUITY
   - flush on BLOCK_FLAG_CORRUPTED
+ packetizers:
   - flush bytestream on  BLOCK_FLAG_DISCONTINUITY and BLOCK_FLAG_CORRUPTED
+ ts-demux:
   - set BLOCK_FLAG_CORRUPTED on incomplete frame (might also happen on
seek)
   - set BLOCK_FLAG_DISCONTINUITY on seeking (time line discontinuity)
   - pass on ts-header discontinuity as BLOCK_FLAG_DISCONTINUITY

Here are the patches:​
 0001-vlc_block.h-Clarify-usage-of-BLOCK_FLAG_DI...
<https://drive.google.com/file/d/0B5sXlFwquWxcY1Z0NlpPbWRhaTA/view?usp=drive_web>
​​
 0002-avcodec-video.c-do-not-drop-good-data-on-d...
<https://drive.google.com/file/d/0B5sXlFwquWxcT1VvNGc0dGo0NTA/view?usp=drive_web>
​​
 0003-ts-demuxer-Passthrough-timeline-discontinu...
<https://drive.google.com/file/d/0B5sXlFwquWxcUzFtT1dpM1U3U1E/view?usp=drive_web>
​​
 0004-qt4-discontinuity-stats-signal-timeline-ch...
<https://drive.google.com/file/d/0B5sXlFwquWxcZjluMnhRRmZwWlE/view?usp=drive_web>
​​
 0005-codec-don-t-drop-discontinue-blocks.patch
<https://drive.google.com/file/d/0B5sXlFwquWxceHJWRE13UHRCMlU/view?usp=drive_web>
​​
 0006-codec-vpx.c-do-not-leak-memory.patch
<https://drive.google.com/file/d/0B5sXlFwquWxcT0RDZW9FVXM2Tjg/view?usp=drive_web>
​​
 0007-packetizer-don-t-drop-blocks-with-DISCONTI...
<https://drive.google.com/file/d/0B5sXlFwquWxcU25KZEY4MkdJSVU/view?usp=drive_web>
​​
 0008-codec-don-t-drop-blocks-marked-BLOCK_FLAG_...
<https://drive.google.com/file/d/0B5sXlFwquWxcQW5WU0F3VV9MRWM/view?usp=drive_web>
​

Kind regards,
Jean-Paul Saman
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20151012/9e93b74a/attachment-0001.html>