[vlc-devel] [PATCH] contrib/growl: Add growl patch that comments out logging

[Vittorio Giovara]

On Fri, Oct 16, 2015 at 6:42 PM,  <epirat07 at gmail.com> wrote:
> From: Marvin Scholz <epirat07 at gmail.com>
>
> The patch comments out logging which causes a warning log message
> when setting the growl bridge delegate to nil. This is a problem,
> as we need to set it to nil, so that the growl bridge will release
> our delegate. Else it will never be released and dealloc will
> not get called.
> ---
>  contrib/src/growl/growl-log-delegate.patch | 14 ++++++++++++++
>  contrib/src/growl/rules.mak                |  1 +
>  2 files changed, 15 insertions(+)
>  create mode 100644 contrib/src/growl/growl-log-delegate.patch
>
> diff --git a/contrib/src/growl/growl-log-delegate.patch b/contrib/src/growl/growl-log-delegate.patch
> new file mode 100644
> index 0000000..869e8db
> --- /dev/null
> +++ b/contrib/src/growl/growl-log-delegate.patch
> @@ -0,0 +1,14 @@
> +diff -ru growl/Framework/Source/GrowlApplicationBridge.m growl-patched/Framework/Source/GrowlApplicationBridge.m
> +--- growl/Framework/Source/GrowlApplicationBridge.m    2011-05-25 04:10:27.000000000 +0200
> ++++ growl-patched/Framework/Source/GrowlApplicationBridge.m    2015-10-15 15:26:27.000000000 +0200
> +@@ -398,8 +398,8 @@
> +       NSDictionary *registrationDictionary = [self registrationDictionaryFromDelegate];
> +       if (!registrationDictionary) {
> +               registrationDictionary = [self registrationDictionaryFromBundle:nil];
> +-              if (!registrationDictionary)
> +-                      NSLog(@"GrowlApplicationBridge: The Growl delegate did not supply a registration dictionary, and the app bundle at %@ does not have one. Please tell this application's developer.", [[NSBundle mainBundle] bundlePath]);
> ++              //if (!registrationDictionary)
> ++                      //NSLog(@"GrowlApplicationBridge: The Growl delegate did not supply a registration dictionary, and the app bundle at %@ does not have one. Please tell this application's developer.", [[NSBundle mainBundle] bundlePath]);

might as well drop them completely, rather than commenting them out
-- 
Vittorio