[vlc-devel] [PATCH 1/1] growl: Add OS X user notifications as fallback to Growl notifications

[Felix Paul Kühne]

> On 16 Oct 2015, at 20:35, Marvin Scholz <epirat07 at gmail.com> wrote:
> 
> On 16 Oct 2015, at 20:30, Rémi Denis-Courmont wrote:
> 
>> Why are you adding this to the Growl plugin? From the description, it has
>> nothing to do with Growl.
> 
> If I wouldn't add those to the Growl plugin, there would be no easy way to fallback
> to OS X notifications only if Growl is not available.
> (At least I could not find any other good solution to this, but I am open for possible
> alternative ways to do this.)

I agree here. However, we might want to rename the module to reflect the change of the focus to something like “OS X notification module” or what not.

It clearly makes sense to keep both code paths together to prevent code duplication or worse duplicate notifications.

Best regards,

Felix