[vlc-devel] [PATCH] growl: Renamed Growl plugin to OS X Notifications

[Rémi Denis-Courmont]

On Monday 19 October 2015 20:58:33 Jean-Baptiste Kempf wrote:
> On 19 Oct, Rémi Denis-Courmont wrote :
> > Le 2015-10-19 20:15, epirat07 at gmail.com a écrit :
> > >From: Marvin Scholz <epirat07 at gmail.com>
> > >
> > >This renames the Growl plugin to OS X Notifications to highlight
> > >the new capabilities and to not advertise Growl so much, as
> > >requested.
> > 
> > Nah. If the user explicitly requested Growl, you should most probably use
> > Growl regardless of the OS version.
> 
> I disagree. Growl is bad and should be killed.

If you want to remove Growl support, then remove Growl support.

Otherwise, if Growl support is included and the user asks for it, the user 
should get it - simple as that.

If the user merely asks for unspecific notifications, then I don´t know nor 
care if Growl should be probed at all on old MacOS versions. Either way, that 
does not seem to require merging Growl and MacOS in a single ugly plugin.

-- 
Rémi Denis-Courmont
http://www.remlab.net/