[vlc-devel] [RFC PATCH] modules: add plugins-blacklist option

[Rémi Denis-Courmont]

On Wednesday 21 October 2015 20:33:37 Thomas Guillem wrote:
> On Wed, Oct 21, 2015, at 19:15, Rémi Denis-Courmont wrote:
> > On Wednesday 21 October 2015 19:10:47 Thomas Guillem wrote:
> > > ---
> > > 
> > >  src/libvlc-module.c |  5 ++++
> > >  src/modules/bank.c  | 71
> > > 
> > > ++++++++++++++++++++++++++++++++++++++--------------- 2 files changed,
> > > 56
> > > insertions(+), 20 deletions(-)
> > > 
> > > diff --git a/src/libvlc-module.c b/src/libvlc-module.c
> > > index a13093d..a959f22 100644
> > > --- a/src/libvlc-module.c
> > > +++ b/src/libvlc-module.c
> > > @@ -1026,6 +1026,9 @@ static const char *const ppsz_prefres[] = {
> > > 
> > >  #define PLUGINS_CACHE_LONGTEXT N_( \
> > >  
> > >      "Use a plugins cache which will greatly improve the startup time of
> > > 
> > > VLC.")
> > > 
> > > +#define PLUGINS_BLACKLIST_TEXT N_("Blacklist plugins")
> > > +#define PLUGINS_BLACKLIST_LONGTEXT N_("List of blacklisted plugins
> > > (won't
> > > be loaded)") +
> > > 
> > >  #define STATS_TEXT N_("Locally collect statistics")
> > >  #define STATS_LONGTEXT N_( \
> > >  
> > >       "Collect miscellaneous local statistics about the playing media.")
> > > 
> > > @@ -1950,6 +1953,8 @@ vlc_module_begin ()
> > > 
> > >                PLUGINS_CACHE_LONGTEXT, true )
> > >      
> > >      add_obsolete_string( "plugin-path" ) /* since 2.0.0 */
> > >      add_obsolete_string( "data-path" ) /* since 2.1.0 */
> > > 
> > > +    add_string( "plugins-blacklist", NULL, PLUGINS_BLACKLIST_TEXT,
> > > +                PLUGINS_BLACKLIST_LONGTEXT, true );
> > 
> > Plugins are (currently) per-process.
> 
> Ah yes, do we want to fix it ? (Attach a plugin bank to libvlc)

No. There is hardly any use  and it drasctically increases the instance 
overhead (which certain VLC developers wrongly complained about).

This patch does not fundamentally need it even. But I don´t see why you even 
need it when we already have accesstweaks.

-- 
Rémi Denis-Courmont
http://www.remlab.net/