[vlc-devel] [RFC PATCH] accesstweaks: add force-cache option

Thomas Guillem thomas at gllm.fr
Thu Oct 22 13:15:19 CEST 2015


On Thu, Oct 22, 2015, at 12:32, Rémi Denis-Courmont wrote:
> Le 2015-10-22 10:32, Thomas Guillem a écrit :
> > Rémi, do you mean something like that ?
> 
> No, I meant that you can turn off fast seek. But it turns out it's too 
> far downstream to affect caching so it won't work.
> 
> Regardless, I don't see much point having a setting here. On the one 
> hand, cache_read can be tested already without any new setting. On the 
> other hand, neither prefetch nor cache_block can be tested effectively 
> even with a forced cache:
> - cache_block requires a block-based access,
> - prefetch requires control on the timing of the underlying access so 
> that the test cases are reproducible (*).

I wanted my test to assure than returns values and positions were the
same between all stream cache when doing a lot of peek/seek at different
position. But this is not needed anymore since I just find out that a
seek should not fail even when seeking after EOF, so I can just assert
on seek return != -1.

For my test, I'll force fastseek to enable/disable prefetch.

> 
> (*) TCP access on loopback, or file access on a FIFO might work. I am 
> not sure.
> 
> -- 
> Rémi Denis-Courmont
> http://www.remlab.net/
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list